fix(settings): Correct hop_limit type for LoRa config#4525
Merged
Conversation
The `hop_limit` property was being incorrectly converted to a Long for the `SingleSelectItem`. This commit corrects the type to align with the form state, removing the unnecessary `toLong()` and `toInt()` conversions. Signed-off-by: James Rich <2199651+jamesarich@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes the LoRa settings “Hop Limit” dropdown not showing the currently configured value by aligning the selectedItem/onItemSelected types with the form state (and the dropdown items), avoiding mismatched equality checks during selection lookup.
Changes:
- Use
IntforselectedIteminstead of convertinghop_limittoLong. - Remove unnecessary
toInt()conversion inonItemSelected, storing the selectedIntdirectly.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4525 +/- ##
=======================================
Coverage 14.42% 14.42%
=======================================
Files 424 424
Lines 14521 14521
Branches 2410 2410
=======================================
Hits 2094 2094
Misses 12124 12124
Partials 303 303 ☔ View full report in Codecov by Sentry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
hop_limitproperty was being incorrectly converted to a Long for theSingleSelectItem. This commit corrects the type to align with the form state, removing the unnecessarytoLong()andtoInt()conversions.addresses #4503