feat: Check if NFC is enabled and prompt user to enable it#4482
Merged
Conversation
- Add a check to see if NFC is enabled before starting a scan. - Implement a dialog to inform the user that NFC is disabled, with a button to open system settings. - Add `nfc_disabled`, `open_settings` and related string resources. - Create an `openNfcSettings` context extension for easy access to NFC settings. - Refactor `MainActivity` to use a common `handleMeshtasticUri` function for both deep links and NFC NDEF messages.
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #4482 +/- ##
========================================
- Coverage 9.22% 9.21% -0.01%
========================================
Files 427 427
Lines 14332 14342 +10
Branches 2385 2385
========================================
Hits 1322 1322
- Misses 12757 12767 +10
Partials 253 253 ☔ View full report in Codecov by Sentry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
nfc_disabled,open_settingsand related string resources.openNfcSettingscontext extension for easy access to NFC settings.MainActivityto use a commonhandleMeshtasticUrifunction for both deep links and NFC NDEF messages.