refactor(build): Introduce AndroidLibraryFlavors convention plugin#4449
Merged
Conversation
This commit extracts the product flavor configuration from the `AndroidLibraryConventionPlugin` into a new, dedicated `AndroidLibraryFlavorsConventionPlugin`. Key changes: - Created `AndroidLibraryFlavorsConventionPlugin` to handle flavor definitions for Android libraries. - Removed flavor configuration logic from `AndroidLibraryConventionPlugin` and added a `missingDimensionStrategy` to handle dependencies on flavored modules. - Registered the new plugin in `build-logic/convention/build.gradle.kts` and `libs.versions.toml`. - Applied the new `meshtastic.android.library.flavors` plugin to relevant feature and core modules. - Simplified publishing configurations in `core:api` and `core:model` from `googleRelease` to the standard `release` variant. Signed-off-by: James Rich <2199651+jamesarich@users.noreply.github.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4449 +/- ##
=====================================
Coverage 8.57% 8.57%
=====================================
Files 420 420
Lines 14184 14184
Branches 2358 2358
=====================================
Hits 1216 1216
Misses 12748 12748
Partials 220 220 ☔ View full report in Codecov by Sentry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit extracts the product flavor configuration from the
AndroidLibraryConventionPlugininto a new, dedicatedAndroidLibraryFlavorsConventionPlugin.Key changes:
AndroidLibraryFlavorsConventionPluginto handle flavor definitions for Android libraries.AndroidLibraryConventionPluginand added amissingDimensionStrategyto handle dependencies on flavored modules.build-logic/convention/build.gradle.ktsandlibs.versions.toml.meshtastic.android.library.flavorsplugin to relevant feature and core modules.core:apiandcore:modelfromgoogleReleaseto the standardreleasevariant.