refactor(model): Make DataPacket fully mutable and fix Parcel reading#4431
Merged
Conversation
Changed `bytes` and `dataType` in the `DataPacket` data class from `val` to `var`, making the entire class mutable. This change fixes a bug in `readFromParcel` where it was unable to update these fields because they were immutable. The implementation of `readFromParcel` has been updated to correctly read `bytes` and `dataType` from the parcel. A new Robolectric test has been added to verify that `readFromParcel` now correctly updates all fields of a `DataPacket` instance. Signed-off-by: James Rich <2199651+jamesarich@users.noreply.github.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4431 +/- ##
========================================
+ Coverage 8.36% 8.60% +0.24%
========================================
Files 418 418
Lines 14318 14320 +2
Branches 2078 2078
========================================
+ Hits 1197 1232 +35
+ Misses 12890 12850 -40
- Partials 231 238 +7 ☔ View full report in Codecov by Sentry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changed
bytesanddataTypein theDataPacketdata class fromvaltovar, making the entire class mutable.This change fixes a bug in
readFromParcelwhere it was unable to update these fields because they were immutable. The implementation ofreadFromParcelhas been updated to correctly readbytesanddataTypefrom the parcel.A new Robolectric test has been added to verify that
readFromParcelnow correctly updates all fields of aDataPacketinstance.