…eString

Migrate feature:settings module from Protobuf Java to Wire:

Core Infrastructure:
- Update ConfigState to use Wire's Message<T, *> and ProtoAdapter
- Replace MessageLite with Message in RadioConfigScreenList
- Fix SettingsViewModel imports and property names (snake_case)
- Update SettingsScreen DeviceProfile import

Config Screens (22 files):
- Migrate all config item lists to use Wire adapters
- Replace copy { } builder syntax with copy() method
- Update property names to snake_case (e.g., isServer → is_server)
- Add null safety for nullable configs
- Fix enum references (e.g., SerialConfig → ModuleConfig.SerialConfig)

Files migrated:
- User, Bluetooth, Device, Display, LoRa, Network, Position, Power, Security
- Telemetry, MQTT, Serial, ExternalNotification, StoreForward, RangeTest
- CannedMessage, Audio, RemoteHardware, NeighborInfo, AmbientLighting
- DetectionSensor, Paxcounter, StatusMessage

Partial migration:
- RadioConfigViewModel: removed builder imports, updated RadioConfigState
- ShutdownConfirmationDialog: partial updates

Remaining work (~680 errors):
- RadioConfigViewModel: deviceProfile builder, SecurityConfig refs, property names
- Navigation files: ConfigRoute, ModuleRoute (Protobuf Java imports)
- DebugViewModel: extensive Protobuf Java usage

Used automated script for bulk replacements of common patterns.

…e properties

Signed-off-by: James Rich <2199651+jamesarich@users.noreply.github.com>

This commit migrates the project from using the `protobuf-java` library to `wire`. This involves changing how Protocol Buffer messages are created, accessed, and serialized throughout the codebase.

Key changes include:
- Replacing builder patterns (`.newBuilder().build()`) with direct constructor instantiation (`MyMessage(...)`).
- Updating field access from `getFieldName()` or `fieldName` to `field_name`.
- Changing `hasFieldName()` checks to nullable property checks (`fieldName != null`).
- Migrating `ByteString` from `com.google.protobuf.ByteString` to `okio.ByteString`.
- Updating serialization/deserialization calls from `parseFrom()` and `toByteArray()` to `MyMessage.ADAPTER.decode()` and `encode()`.
- Adjusting enum value access from `get...Value()` or `.number` to `.value`.
- Removing `copy { ... }` blocks in favor of the `copy(...)` data class method.

This refactoring affects various features, including node management, configuration handling, messaging, mapping, and data handling services, leading to more idiomatic Kotlin code for protobuf interactions.

Signed-off-by: James Rich <2199651+jamesarich@users.noreply.github.com>

Removes a number of extraneous line breaks and trailing commas throughout the codebase, primarily within data class and protobuf message instantiations. This change is purely stylistic and has no effect on the application's logic.

Signed-off-by: James Rich <2199651+jamesarich@users.noreply.github.com>

This commit contains various minor cleanups and refactoring within the test suite. The primary change is the removal of redundant multi-line object instantiations, converting them into single-line statements for improved readability across multiple test files. Additionally, the copyright year has been updated in some test files. No functional changes are included.

Signed-off-by: James Rich <2199651+jamesarich@users.noreply.github.com>

Refreshes the detekt baseline to reflect the latest codebase state. This includes removing resolved issues and adding new ones to suppress warnings for the time being.

Signed-off-by: James Rich <2199651+jamesarich@users.noreply.github.com>

This commit completes the migration from `com.google.protobuf` to the Wire library for handling protocol buffers.

- Deletes `UserExtensions.kt` as its functionality is no longer needed with Wire's generated data classes.
- Updates data repositories, tests, and service handlers to use Wire's generated classes and their direct property access (e.g., `user.long_name` instead of `user.longName`).
- Modifies entity and model classes (`MeshLog`) to correctly interact with the new Wire objects.
- Adjusts ProGuard rules to keep the new Wire-generated classes.

Signed-off-by: James Rich <2199651+jamesarich@users.noreply.github.com>

Removes redundant null-safe operators (`?: 0`, `?: 0f`, `?: false`, `?: ""`) on protobuf fields that are now non-nullable. This simplifies the code by removing unnecessary checks for default values.

Signed-off-by: James Rich <2199651+jamesarich@users.noreply.github.com>

Protobuf boolean and numeric fields now have non-nullable types, so the explicit `?: 0`, `?: false`, and `== true` checks are no longer necessary. This change cleans up the code by removing this redundant logic.

Signed-off-by: James Rich <2199651+jamesarich@users.noreply.github.com>

This commit introduces several refactoring changes to improve null safety and simplify the codebase.

-   In `RouteDiscovery.kt`, the destination and source IDs are now correctly read from the data payload (`d.dest` and `d.source`) for more reliable route creation.
-   The `MeshServiceNotificationsImpl.kt` file has been updated to use Kotlin's `when` expression for better readability and has removed redundant null checks by leveraging non-nullable types, particularly for notification messages and telemetry data formatting.
-   Extension functions for `LocalStats` and `DeviceMetrics` now operate on non-nullable receivers, simplifying their implementation.

Signed-off-by: James Rich <2199651+jamesarich@users.noreply.github.com>

This commit refactors the build scripts for `core/api`, `core/model`, and `core/proto` to align with modern Kotlin Multiplatform (KMP) publishing practices.

Key changes include:
- Removing explicit `googleRelease` publications in favor of default KMP behavior.
- Renaming the default `proto` artifact to `core-proto` for consistency across modules.
- Introducing a convention plugin (`meshtastic.kmp.library`) to simplify the `core/proto` build script.
- Standardizing the placement of `afterEvaluate` publishing blocks and cleaning up minor code formatting in various Gradle and source files.

Signed-off-by: James Rich <2199651+jamesarich@users.noreply.github.com>

Resolved conflicts in metrics charts:
- DeviceMetrics.kt: Combined snake_case properties (HEAD) with upstream filtering logic.
- PowerMetrics.kt: Updated retrieveCurrent/retrieveVoltage to return NaN for missing values to support upstream's filtering logic.
- SignalMetrics.kt: Applied upstream filtering (non-zero RSSI, non-NaN SNR) to HEAD's property names.
- EnvironmentCharts.kt: Preserved upstream's filtering structure ensuring x/y synchronization, while using HEAD's property accessors.

…g for SFPP hashes

This commit refactors several parts of the codebase to modernize protobuf usage and improve data type consistency.

Key changes include:
- Replaced the deprecated protobuf builder syntax (e.g., `channelSet { ... }`) with direct constructor calls (e.g., `ChannelSet(...)`). This affects various tests and utility functions.
- Changed the data type for SFPP hashes from `ByteArray` to `okio.ByteString` in the `PacketRepository` and `PacketDao`. This provides a more robust and idiomatic way to handle binary data.
- Updated database queries and test assertions to work with `ByteString` for SFPP hash comparisons.
- Removed redundant code and simplified logic in `ChannelSet.kt` and `ModuleRoute.kt`.
- Added a custom `testInstrumentationRunner` to the app's `build.gradle.kts` file.

Signed-off-by: James Rich <2199651+jamesarich@users.noreply.github.com>

Adds the `okio.ByteString.Companion.toByteString` import to the `ChannelSet.kt` file.

Signed-off-by: James Rich <2199651+jamesarich@users.noreply.github.com>

Renamed the `String.toByteString()` extension function to `String.base64ToByteString()` to more accurately reflect its purpose of decoding a Base64 string.

This change includes:
- Adding KDoc to clarify that the function decodes a Base64 string and can throw an `IllegalArgumentException`.
- Updating the `EditBase64Preference` component to use the new function name.

Signed-off-by: James Rich <2199651+jamesarich@users.noreply.github.com>

Moves the Kover XML report generation and Codecov upload to a separate `coverage` job. This new job runs after the `androidTest` job completes. The `koverXmlReport` task is removed from the test execution script within the `androidTest` job.

Signed-off-by: James Rich <2199651+jamesarich@users.noreply.github.com>

This commit enhances the ProGuard configuration for Protobuf classes, ensuring all necessary classes for packet handling, serialization, and configuration are kept during release builds. This prevents potential crashes due to class stripping by R8.

Additionally, this commit improves null safety in the `FromRadioPacketHandler` and `MeshDataHandler` by replacing non-null assertions (`!!`) with safe calls (`?.let`), reducing the risk of `NullPointerException`s.

Signed-off-by: James Rich <2199651+jamesarich@users.noreply.github.com>

Replaced the spread operator (`*bytes`) in `ByteString.of(*bytes)` with the more efficient `bytes.toByteString()` extension function.

This change also allowed for the removal of the `@Suppress("SpreadOperator")` annotation.

Signed-off-by: James Rich <2199651+jamesarich@users.noreply.github.com>

This commit refactors the GitHub Actions workflows to improve efficiency and simplify the CI process.

Key changes include:
- Consolidating the `coverage` job into the `androidTest` job within the `reusable-android-test.yml` workflow. This generates and uploads Kover coverage reports and test results in a single job.
- Combining coverage and test result uploads into a single Codecov action step in the `reusable-android-build.yml` workflow.
- Disabling test sharding for pull requests by removing `num_shards` from the `pull-request.yml` workflow, as it was not providing performance benefits.

Signed-off-by: James Rich <2199651+jamesarich@users.noreply.github.com>

Introduces the `org.gradle.test-retry` Gradle plugin to automatically retry failed tests.

This change applies the plugin to both Android application and library modules. It configures a maximum of 2 retries per failed test and a total of 10 max failures for a test suite. The build will not fail if a test passes upon retry.

Signed-off-by: James Rich <2199651+jamesarich@users.noreply.github.com>

Signed-off-by: James Rich <2199651+jamesarich@users.noreply.github.com>

This commit enables Gradle's Isolated Projects feature for improved build performance and correctness by making several key adjustments to the build logic.

- Enables `org.gradle.isolated-projects=true` in `gradle.properties`.
- Refactors `Dokka.kt` and `Kover.kt` aggregation logic to be compatible with isolated projects by adding all subprojects as dependencies directly, rather than iterating and checking for plugins.
- Simplifies and rewrites the module dependency graph generation logic in `Graph.kt` to work within the constraints of isolated projects, removing the recursive and configuration-phase heavy implementation.
- Cleans up and organizes `gradle.properties` for better readability, adding more optimization flags for AGP, Kotlin, and KSP.
- Adds a separate `gradle.properties` for the `build-logic` included build.

Signed-off-by: James Rich <2199651+jamesarich@users.noreply.github.com>

…aggregation

Signed-off-by: James Rich <2199651+jamesarich@users.noreply.github.com>

# Conflicts:
#	.github/workflows/pull-request.yml

Signed-off-by: James Rich <2199651+jamesarich@users.noreply.github.com>

This commit introduces several small refactorings and fixes across the codebase:

- Clamps non-positive parameters to zero when building a `StoreAndForward` history request.
- Simplifies boolean logic using the Elvis operator (`?:`) in `IsEffectivelyUnmessageable`, `BaseMapViewModel`, and `MeshLog`.
- Filters out the "UNRECOGNIZED" option from the Bluetooth pairing mode dropdown.
- Excludes telemetry data with a timestamp of 0 from environment charts.
- Adds a new string resource `filter_disable_for_contact`.
- Removes an unused `loadingMessage` variable in `NodeDetailScreen`.

Signed-off-by: James Rich <2199651+jamesarich@users.noreply.github.com>

Exclude `build` and `dependencies` directories from the Kotlin Gradle target in the Spotless configuration to prevent unnecessary formatting checks on generated or vendored files.

Signed-off-by: James Rich <2199651+jamesarich@users.noreply.github.com>

Signed-off-by: James Rich <2199651+jamesarich@users.noreply.github.com>

This commit addresses an issue with the manual parceling of the `DataPacket` class, specifically how the `MessageStatus` enum is read from a Parcel.

The previous implementation was incorrect, causing `MessageStatus` to be consistently deserialized as null. This has been fixed by manually reading the presence flag and string value that `Parcelize` writes for enums, ensuring correct restoration.

Additionally, Robolectric tests have been added to verify the `DataPacket` parcelization logic, covering both full and null-field scenarios to prevent future regressions.

Signed-off-by: James Rich <2199651+jamesarich@users.noreply.github.com>

The Dependency Guard plugin and its associated configuration and workflow tasks have been removed from the project.

Signed-off-by: James Rich <2199651+jamesarich@users.noreply.github.com>

This change configures the Wire code generator to flatten `oneof` fields.

By setting `boxOneOfsMinSize` to a large value, the intermediate sealed classes for `oneof` fields are removed. Instead, the fields are generated as nullable properties on the parent class. This simplifies code usage and reduces the generated method count and binary size. The existing codebase is already aligned with this flattened structure.

Signed-off-by: James Rich <2199651+jamesarich@users.noreply.github.com>

This commit introduces several code cleanups and minor refactorings across the application to improve clarity, remove redundancy, and enhance efficiency.

Key changes include:
- **Refactoring:** Simplified logic in `FromRadioPacketHandler`, `DebugViewModel`, and `MeshDataHandler` by removing redundant variables, unnecessary checks, and complex structures. Replaced `if/else` and `when` statements with more direct returns and property access.
- **Nullability:** Changed the return type of `TypeConverter` functions in `Converters.kt` from nullable to non-nullable `ByteArray`, ensuring type safety.
- **Efficiency:** Removed unused assignments and simplified chained calls in `PacketHandler` and `MeshMessageProcessor`.
- **Readability:** Improved code formatting and introduced local variables in `FromRadioPacketHandler` and `MeshDataHandler` for better readability.
- **Testing:** Streamlined test case setup in `DataPacketParcelTest`.

Signed-off-by: James Rich <2199651+jamesarich@users.noreply.github.com>

# Conflicts:
#	core/model/src/main/kotlin/org/meshtastic/core/model/DataPacket.kt

- Updates Robolectric test configuration to target SDK 34.
- Adds `@Suppress("DEPRECATION")` to handle the deprecated `readParcelable` method in `DataPacketParcelTest`.
- Refactors `DataPacketTest` to use `ByteString` and `assertEquals` for byte array comparisons, improving test clarity and consistency.

Signed-off-by: James Rich <2199651+jamesarich@users.noreply.github.com>

This commit refactors the `reusable-check.yml` workflow to run jobs in a matrix across different product flavors (`google`, `fdroid`), in addition to the existing API level matrix.

Key changes include:
- Renamed the workflow input `test_flavors` to `flavors` and changed its type to a JSON array string.
- Added `flavor` to the build matrix, allowing parallel execution for each specified flavor.
- Updated Gradle tasks to run for the specific flavor in the matrix, rather than using conditional logic for `google`, `fdroid`, or `both`.
- Lint and unit tests now run only on the first API level *and* the first flavor in the matrix to conserve resources.
- Simplified artifact uploading by using the matrix `flavor` to dynamically name the artifact and define its path.
- Updated `pull-request.yml`, `merge-queue.yml`, and `release.yml` to use the new `flavors` input.

Signed-off-by: James Rich <2199651+jamesarich@users.noreply.github.com>