chore: fix regressions in the release#4398
Merged
Merged
Conversation
Removes the `FOREGROUND_SERVICE_DATA_SYNC` permission and its corresponding `foregroundServiceType` from the `AndroidManifest.xml`. Signed-off-by: James Rich <2199651+jamesarich@users.noreply.github.com>
This commit introduces two key improvements to the Nordic BLE interface: - Wraps the `fromRadioCharacteristic` read operation in a `try-catch` block. This prevents crashes by gracefully handling exceptions that can occur during disconnection, logging a warning instead. - Clears all BLE characteristics (`toRadioCharacteristic`, `fromNumCharacteristic`, `fromRadioCharacteristic`, `logRadioCharacteristic`) to null when a `Disconnected` state is observed. This ensures a clean state and prevents the use of stale characteristic references upon reconnection. Signed-off-by: James Rich <2199651+jamesarich@users.noreply.github.com>
Filters out `NaN` (Not a Number) values from various telemetry and metrics data points before they are rendered in the device, environment, power, and signal charts. This prevents potential crashes or rendering issues in the charting library when encountering invalid data. Signed-off-by: James Rich <2199651+jamesarich@users.noreply.github.com>
- Refactored the `fromRadioPacketFlow` in `NordicBleInterface.kt` to use a `try-catch` block around the characteristic read operation, simplifying error handling and improving the flow's readability. - Applied minor code reformatting in `EnvironmentCharts.kt` for better style consistency. Signed-off-by: James Rich <2199651+jamesarich@users.noreply.github.com>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4398 +/- ##
========================================
- Coverage 8.35% 8.35% -0.01%
========================================
Files 418 418
Lines 14304 14311 +7
Branches 2075 2076 +1
========================================
Hits 1195 1195
- Misses 12878 12885 +7
Partials 231 231 ☔ View full report in Codecov by Sentry. |
To improve build performance and security, this change configures Gradle to only resolve dependencies with the group ID matching `com.github.*` from the JitPack repository. This is applied to the dependency resolution management in both the root `settings.gradle.kts` and the `build-logic/settings.gradle.kts` files. Signed-off-by: James Rich <2199651+jamesarich@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request focuses on two main areas: improving the robustness of metrics charting by filtering out invalid (NaN) data points, and removing the use of the
dataSyncforeground service type and associated permission from the Android app. Additionally, there are minor improvements to BLE connection handling for increased reliability.Metrics Charting Improvements:
feature/nodemodule now filter out NaN or invalid values before plotting, ensuring that charts display only valid data and preventing potential rendering issues. This affects device metrics, environment metrics, power metrics, and signal metrics charts. [1] [2] [3] [4]Foreground Service and Permissions Cleanup:
android.permission.FOREGROUND_SERVICE_DATA_SYNCpermission and thedataSyncforeground service type from both the manifest and service declarations, simplifying the app's permissions and foreground service requirements. [1] [2] [3]BLE Connection Handling: