chore(ci): Remove GitHub Packages publishing workflow#4368
Merged
Conversation
The `publish-packages.yml` workflow, responsible for publishing packages to GitHub Packages on release creation, has been deleted. Dependencies in the `mesh_service_example` have been updated to fetch artifacts from JitPack instead of using local project modules. This aligns the example app with how external consumers would use the libraries. Other related changes include: - Removing the `maven-publish` plugin from the `KmpLibraryConventionPlugin` and `AndroidLibraryConventionPlugin`. - Updating `jitpack.yml` to publish specific core modules to Maven Local and set the `group`. - Improving the service binding logic in the example app to dynamically find the service package name. - Enhancing the version determination logic in `publishing.gradle.kts`. Signed-off-by: James Rich <2199651+jamesarich@users.noreply.github.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4368 +/- ##
=====================================
Coverage 0.00% 0.00%
=====================================
Files 3 3
Lines 28 28
Branches 8 8
=====================================
Misses 28 28 ☔ View full report in Codecov by Sentry. |
The `mesh_service_example` now uses local project dependencies for `core-api`, `core-model`, and `core-proto` instead of fetching them as remote artifacts. This simplifies the build process and ensures the example app is always built against the current source code. Signed-off-by: James Rich <2199651+jamesarich@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
publish-packages.ymlworkflow, responsible for publishing packages to GitHub Packages on release creation, has been deleted.Dependencies in the
mesh_service_examplehave been updated to fetch artifacts from JitPack instead of using local project modules. This aligns the example app with how external consumers would use the libraries.Other related changes include:
maven-publishplugin from theKmpLibraryConventionPluginandAndroidLibraryConventionPlugin.jitpack.ymlto publish specific core modules to Maven Local and set thegroup.publishing.gradle.kts.