feat: Add JitPack configuration for publishing#4365
Merged
Conversation
This commit introduces a `jitpack.yml` file to enable building and publishing the library via JitPack. It also adjusts module dependencies to correctly expose required APIs for consumers of the library. ### Key Changes: - **JitPack Configuration:** Added a `jitpack.yml` file to specify `openjdk21` and a `before_install` step to generate protobuf classes, ensuring the build succeeds on JitPack's servers. - **Dependency Scope:** In the `core:model` module, dependencies on `core:proto`, `androidx.annotation`, and `kotlinx.serialization.json` were changed from `implementation` to `api`. This transitively exposes these essential APIs to projects that consume the `core:model` library. - **Plugin Removal:** The `meshtastic.android.library.compose` plugin, which was not needed, was removed from the `core:proto` module. Signed-off-by: James Rich <2199651+jamesarich@users.noreply.github.com>
This commit removes the configuration for publishing to GitHub Packages from the `publishing.gradle.kts` file. The logic that set up the Maven repository using `GITHUB_ACTOR` and `GITHUB_TOKEN` environment variables has been deleted. Signed-off-by: James Rich <2199651+jamesarich@users.noreply.github.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4365 +/- ##
=====================================
Coverage 0.00% 0.00%
=====================================
Files 3 3
Lines 28 28
Branches 8 8
=====================================
Misses 28 28 ☔ View full report in Codecov by Sentry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thank you for sending in a pull request, here's some tips to get started!
(Please delete all these tips and replace with your text)