fix(neighborinfo): disable neighbor info dialog temporarily#4345
Merged
Conversation
The `canRequestNeighborInfo` capability has been temporarily disabled because the feature is not working as expected. This change involves: - Hardcoding the `canRequestNeighborInfo` capability to `false`. - Updating the corresponding tests to reflect that the feature is now disabled for all firmware versions. - Commenting out the UI code in `Main.kt` that was responsible for displaying the NeighborInfo response dialog. Signed-off-by: James Rich <2199651+jamesarich@users.noreply.github.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4345 +/- ##
=====================================
Coverage 0.00% 0.00%
=====================================
Files 3 3
Lines 28 28
Branches 8 8
=====================================
Misses 28 28 ☔ View full report in Codecov by Sentry. |
DaneEvans
approved these changes
Jan 28, 2026
Collaborator
|
That's a hammer, but it makes sense. The code that should suppress it isn't doing so at the moment, I'll hopefully get to it this afternoon. |
to ensure debug override test still works Signed-off-by: James Rich <2199651+jamesarich@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
canRequestNeighborInfocapability has been temporarily disabled because the feature is not working as expected.This change involves:
canRequestNeighborInfocapability tofalse.Main.ktthat was responsible for displaying the NeighborInfo response dialog.resolves #4285 until we can get it working properly. 😞