fix(notifications): Suppress notifications for muted contacts an…#4323
Merged
Conversation
…d nodes This commit prevents notifications from being generated for messages or reactions from muted contacts or nodes. The `isSilent` flag, which checks if either a conversation or a specific node is muted, is now used to conditionally suppress notification creation for both text messages and emoji reactions. This ensures that user preferences for muting are respected. ### Key Changes: - **Message Notifications:** In `MeshDataHandler`, a check for `!isSilent` is added before updating a message notification, preventing it from appearing if the sender or conversation is muted. - **Reaction Notifications:** The logic for creating reaction notifications is now wrapped in an `if (!isSilent)` block, stopping notifications for reactions from muted sources. - **Code Style:** Minor code formatting changes were applied for improved readability in `NetworkRepository.kt`. - **Copyright Year:** Updated the copyright year to 2026 in `SerialConnectionImpl.kt`. Signed-off-by: James Rich <2199651+jamesarich@users.noreply.github.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4323 +/- ##
=====================================
Coverage 0.00% 0.00%
=====================================
Files 3 3
Lines 28 28
Branches 8 8
=====================================
Misses 28 28 ☔ View full report in Codecov by Sentry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
prevents notifications from being generated for messages or reactions from muted contacts or nodes.
The
isSilentflag, which checks if either a conversation or a specific node is muted, is now used to conditionally suppress notification creation for both text messages and emoji reactions. This ensures that user preferences for muting are respected.Key Changes:
MeshDataHandler, a check for!isSilentis added before updating a message notification, preventing it from appearing if the sender or conversation is muted.if (!isSilent)block, stopping notifications for reactions from muted sources.resolves #4303