refactor(core): Optimize and share network state flows#4320
Merged
Conversation
This commit optimizes the `NetworkRepository` by converting `networkAvailable` and `resolvedList` from simple properties into shared, lazy-initialized flows.
By using `shareIn` with `SharingStarted.WhileSubscribed`, these flows now remain active for 5 seconds after the last subscriber is gone, preventing unnecessary re-subscriptions and resource churn. `distinctUntilChanged` is also added to `networkAvailable` to avoid emitting redundant state updates.
### Key Changes:
- **`NetworkRepository.kt`**:
- Changed `networkAvailable` and `resolvedList` to be `lazy` properties.
- Both flows now use `shareIn` to broadcast their state to multiple subscribers efficiently, with a `WhileSubscribed` strategy.
- `networkAvailable` now uses `distinctUntilChanged()` to prevent duplicate emissions.
- The flows are scoped to the `processLifecycle`, ensuring they align with the application's lifecycle.
- **`RadioInterfaceService.kt`**:
- Introduced a thread-safe, double-checked locking mechanism to ensure state listeners in `initStateListeners()` are initialized only once.
Signed-off-by: James Rich <2199651+jamesarich@users.noreply.github.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4320 +/- ##
=====================================
Coverage 0.00% 0.00%
=====================================
Files 3 3
Lines 28 28
Branches 8 8
=====================================
Misses 28 28 ☔ View full report in Codecov by Sentry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
optimizes the
NetworkRepositoryby convertingnetworkAvailableandresolvedListfrom simple properties into shared, lazy-initialized flows.By using
shareInwithSharingStarted.WhileSubscribed, these flows now remain active for 5 seconds after the last subscriber is gone, preventing unnecessary re-subscriptions and resource churn.distinctUntilChangedis also added tonetworkAvailableto avoid emitting redundant state updates.Key Changes:
NetworkRepository.kt:networkAvailableandresolvedListto belazyproperties.shareInto broadcast their state to multiple subscribers efficiently, with aWhileSubscribedstrategy.networkAvailablenow usesdistinctUntilChanged()to prevent duplicate emissions.processLifecycle, ensuring they align with the application's lifecycle.RadioInterfaceService.kt:initStateListeners()are initialized only once.