feat: Improve channel migration logic and add tests#4294
Merged
Conversation
Improves the channel migration logic in `PacketDao.migrateChannelsByPSK`. The new implementation is more robust in handling channel reordering and ambiguity. When multiple new channels share the same Pre-Shared Key (PSK), the migration now attempts to disambiguate by matching channel names. If ambiguity still exists, it prefers to map the channel to the same index if possible. This change also adds `MigrationTest.kt` with unit tests for various migration scenarios, including: - Reordering of channels. - Disambiguation by name when PSKs are identical. - Prioritizing the original index when ambiguity remains. - Handling duplicate PSKs. Additionally, testing dependencies such as Robolectric, AndroidX Test, and Room Testing have been added to support these new database tests.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4294 +/- ##
=====================================
Coverage 0.00% 0.00%
=====================================
Files 3 3
Lines 23 23
Branches 7 7
=====================================
Misses 23 23 ☔ View full report in Codecov by Sentry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improves the channel migration logic in
PacketDao.migrateChannelsByPSK. The new implementation is more robust in handling channel reordering and ambiguity.When multiple new channels share the same Pre-Shared Key (PSK), the migration now attempts to disambiguate by matching channel names. If ambiguity still exists, it prefers to map the channel to the same index if possible.
This change also adds
MigrationTest.ktwith unit tests for various migration scenarios, including:Additionally, testing dependencies such as Robolectric, AndroidX Test, and Room Testing have been added to support these new database tests.
resolves #4293