refactor(firmware): Simplify ESP32 firmware check#4272
Merged
Conversation
This commit refactors the firmware retrieval process to consistently prioritize Unified OTA binaries for all ESP32-based devices. The logic no longer differentiates based on UI capabilities (like MUI or E-Ink) or an explicit `supportsUnifiedOta` flag. This change simplifies the codebase by removing the `supportsUnifiedOta` property and related special handling, relying instead on the device's architecture to determine the appropriate firmware path. ### Key Changes: - **Unified OTA Priority:** The `FirmwareRetriever` now always attempts to download the architecture-specific Unified OTA binary first for all ESP32 devices (e.g., `mt-esp32-ota.bin`, `mt-esp32s3-ota.bin`). - **Removed `supportsUnifiedOta`:** The `supportsUnifiedOta` flag has been removed from `DeviceHardware`, `BootloaderOtaQuirk`, and the `device_bootloader_ota_quirks.json` asset file, as it is now redundant. - **`isEsp32Arc` Helper:** A new `isEsp32Arc` property was added to the `DeviceHardware` model to simplify checking if a device is ESP32-based. This is now used in `SettingsViewModel` to determine OTA availability. Signed-off-by: James Rich <2199651+jamesarich@users.noreply.github.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4272 +/- ##
=====================================
Coverage 0.00% 0.00%
=====================================
Files 3 3
Lines 23 23
Branches 7 7
=====================================
Misses 23 23 ☔ View full report in Codecov by Sentry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit refactors the firmware retrieval process to consistently prioritize Unified OTA binaries for all ESP32-based devices. The logic no longer differentiates based on UI capabilities (like MUI or E-Ink) or an explicit
supportsUnifiedOtaflag.This change simplifies the codebase by removing the
supportsUnifiedOtaproperty and related special handling, relying instead on the device's architecture to determine the appropriate firmware path.Key Changes:
FirmwareRetrievernow always attempts to download the architecture-specific Unified OTA binary first for all ESP32 devices (e.g.,mt-esp32-ota.bin,mt-esp32s3-ota.bin).supportsUnifiedOta: ThesupportsUnifiedOtaflag has been removed fromDeviceHardware,BootloaderOtaQuirk, and thedevice_bootloader_ota_quirks.jsonasset file, as it is now redundant.isEsp32ArcHelper: A newisEsp32Arcproperty was added to theDeviceHardwaremodel to simplify checking if a device is ESP32-based. This is now used inSettingsViewModelto determine OTA availability.