feat(connections): Improve connection screen UI and logic#4224
Merged
Conversation
This commit introduces several enhancements to the connection screen's user interface and underlying logic for a smoother user experience. Key changes include: - A new "No device selected" empty state is displayed on the connection screen when no device is active. - The screen now shows a dedicated "Connecting" state with device info while a connection is being established. - MyNodeInfo is now cleared from the database upon initiating a new connection to prevent displaying stale information. - The "Add network device" dialog now accepts both IP addresses and domain names. - The `MeshService` is now properly stopped when it's no longer needed in the foreground. Signed-off-by: James Rich <2199651+jamesarich@users.noreply.github.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4224 +/- ##
=====================================
Coverage 0.00% 0.00%
=====================================
Files 3 3
Lines 23 23
Branches 7 7
=====================================
Misses 23 23 ☔ View full report in Codecov by Sentry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit introduces several enhancements to the connection screen's user interface and underlying logic for a smoother user experience.
Key changes include:
MeshServiceis now properly stopped when it's no longer needed in the foreground.Screen_recording_20260115_084632.mp4