refactor(messaging): Redesign message bubbles and reaction UI#4217
Merged
Conversation
This commit refactors the message item display for a cleaner and more intuitive user interface.
- **Message Bubble Redesign:**
- The user's name is now displayed above the message bubble for incoming messages, rather than inside it.
- Padding and spacing have been adjusted for a less cluttered look. Local messages are indented further for clearer distinction.
- Text size for the message body has been increased (`bodyMedium` to `bodyLarge`).
- The layout of metadata (SNR, RSSI, timestamp, status icon) within the bubble has been streamlined.
- **Reaction UI Improvements:**
- An "Add Reaction" button (`+` icon) is now persistently visible next to existing reactions, providing a clear entry point for adding new ones.
- The visual style of reaction items has been updated. They now use `SurfaceVariant` with a border instead of `PrimaryContainer`, and the count is displayed next to the emoji rather than as a badge.
- The "React" icon in the message action sheet has been changed from `EmojiEmotions` to the more specific `AddReaction`.
- **Code & Layout Cleanup:**
- Reactions are now displayed below the message bubble using `AnimatedVisibility`, preventing them from overlapping with the bubble.
- The logic for determining message bubble corner rounding has been corrected to properly handle consecutive messages from the same sender.
Signed-off-by: James Rich <2199651+jamesarich@users.noreply.github.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4217 +/- ##
=====================================
Coverage 0.00% 0.00%
=====================================
Files 3 3
Lines 23 23
Branches 7 7
=====================================
Misses 23 23 ☔ View full report in Codecov by Sentry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit refactors the message item display for a cleaner and more intuitive user interface.
Message Bubble Redesign:
bodyMediumtobodyLarge).Reaction UI Improvements:
+icon) is now persistently visible next to existing reactions, providing a clear entry point for adding new ones.SurfaceVariantwith a border instead ofPrimaryContainer, and the count is displayed next to the emoji rather than as a badge.EmojiEmotionsto the more specificAddReaction.Code & Layout Cleanup:
AnimatedVisibility, preventing them from overlapping with the bubble.