Refactor: Improve MessageItem layout and styling#4208
Merged
Conversation
This commit refactors the `MessageItem` component with the following changes: - Removes `OutlinedCard` and replaces it with `Surface` for the original message snippet to allow for more flexible shaping. - Adjusts padding and offsets for reaction emojis for better visual alignment. - Reverses the order of reaction emojis for messages sent by the local user. - Passes `hasSamePrev` to `OriginalMessageSnippet` to enable dynamic message bubble shaping, improving the continuity of replied messages in the chat. Signed-off-by: James Rich <2199651+jamesarich@users.noreply.github.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4208 +/- ##
=====================================
Coverage 0.00% 0.00%
=====================================
Files 3 3
Lines 23 23
Branches 7 7
=====================================
Misses 23 23 ☔ View full report in Codecov by Sentry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit refactors the
MessageItemcomponent with the following changes:OutlinedCardand replaces it withSurfacefor the original message snippet to allow for more flexible shaping.hasSamePrevtoOriginalMessageSnippetto enable dynamic message bubble shaping, improving the continuity of replied messages in the chat.followup to #4206
