feat: Add acknowledgement status and retry for emoji reactions#4142
Merged
Conversation
7b80435 to
e7f4ba8
Compare
This commit introduces status tracking and a resend mechanism for message reactions. - Adds status-related fields (`status`, `packetId`, `routingError`, etc.) to the `ReactionEntity` to monitor delivery. - Bumps the database version to 28 and adds the corresponding schema. - Implements `update` and `getReactionByPacketId` functions in `PacketDao` and `PacketRepository`. - Updates the UI to display the status of reactions, including a dimmed state for sending and an error state. - Adds a dialog to show delivery details and a "resend" option for failed reactions. - Ensures reactions are sent with `wantAck=true` and are stored with a `QUEUED` status upon creation. - Handles ACKs/NAKs for reactions in `MeshDataHandler` to update their status and implement a retry mechanism. Signed-off-by: James Rich <2199651+jamesarich@users.noreply.github.com>
e7f4ba8 to
9732116
Compare
Signed-off-by: James Rich <2199651+jamesarich@users.noreply.github.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4142 +/- ##
=====================================
Coverage 0.00% 0.00%
=====================================
Files 2 2
Lines 19 19
Branches 7 7
=====================================
Misses 19 19 ☔ View full report in Codecov by Sentry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This introduces status tracking and a resend mechanism for message reactions.
status,packetId,routingError, etc.) to theReactionEntityto monitor delivery.updateandgetReactionByPacketIdfunctions inPacketDaoandPacketRepository.wantAck=trueand are stored with aQUEUEDstatus upon creation.MeshDataHandlerto update their status and implement a retry mechanism.