feat: Add separate notifications for waypoints#4131
Merged
Conversation
This change introduces a dedicated notification channel for waypoints, separating them from regular text message notifications. This includes: - A new `Waypoint` notification type with `IMPORTANCE_LOW`. - A `meshtastic_waypoints_notifications` string for the channel name. - `updateWaypointNotification` function to create and display waypoint-specific notifications. - Refactoring `MeshDataHandler` to route waypoint packets to the new notification function. Signed-off-by: James Rich <2199651+jamesarich@users.noreply.github.com>
Adds the ability to navigate to a specific waypoint on the map directly from a notification. - The `Map` route now accepts an optional `waypointId` parameter. - Tapping a waypoint notification will now open the map and center it on the corresponding waypoint. - The importance of waypoint notifications has been increased to `IMPORTANCE_DEFAULT` to make them more visible. Signed-off-by: James Rich <2199651+jamesarich@users.noreply.github.com>
When navigating to the map with a specific waypoint ID, automatically open its info window. This enhances user experience by directly highlighting the selected waypoint upon map view initialization. Signed-off-by: James Rich <2199651+jamesarich@users.noreply.github.com>
Updates the copyright year to 2026 across multiple files. Also, removes unnecessary blank lines and cleans up function signatures for consistency. Signed-off-by: James Rich <2199651+jamesarich@users.noreply.github.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4131 +/- ##
=====================================
Coverage 0.00% 0.00%
=====================================
Files 2 2
Lines 19 19
Branches 7 7
=====================================
Misses 19 19 ☔ View full report in Codecov by Sentry. |
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds separate notifs for waypoints, opens to map centered on waypoint with Info window displayed.
resolves #4103
Screen_recording_20260104_113411.mp4