feat: Improve node handling and add client notifications#4130
Merged
Conversation
This commit introduces several improvements to node management and user notifications. - **Client Notifications**: Displays notifications received from the device, ensuring users are alerted to important events. - **Node Upsert Logic**: Refines node database updates to prevent overwriting existing user information (like names) with placeholder data from new, unconfigured nodes. It also improves handling of public key mismatches. - **Port Zero Prevention**: Throws an `IllegalArgumentException` if an attempt is made to send data on port zero, which is reserved. - **Database Switching**: Clears the early packet buffer when switching between device databases to prevent data from one device leaking into another's session. Signed-off-by: James Rich <2199651+jamesarich@users.noreply.github.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4130 +/- ##
=====================================
Coverage 0.00% 0.00%
=====================================
Files 2 2
Lines 19 19
Branches 7 7
=====================================
Misses 19 19 ☔ View full report in Codecov by Sentry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes some regressions to node management and user notifications.
IllegalArgumentExceptionif an attempt is made to send data on port zero, which is reserved.