feat: Send emoji codepoint in reaction packets#4123
Merged
Conversation
This commit adds the integer codepoint of the emoji to reaction packets. This allows other clients and the device firmware to correctly handle reactions without needing to parse the string representation. It also introduces an `AtomicBoolean` in `NsdManager` to prevent multiple resume calls in the service resolution coroutine, improving its robustness. Additionally, the `MeshActionHandler` is refactored for better readability by extracting logic into separate private functions. Signed-off-by: James Rich <2199651+jamesarich@users.noreply.github.com>
Disables the `org.gradle.vfs.watch` property. Signed-off-by: James Rich <2199651+jamesarich@users.noreply.github.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4123 +/- ##
=====================================
Coverage 0.00% 0.00%
=====================================
Files 2 2
Lines 19 19
Branches 7 7
=====================================
Misses 19 19 ☔ View full report in Codecov by Sentry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit adds the integer codepoint of the emoji to reaction packets. This allows other clients and the device firmware to correctly handle reactions without needing to parse the string representation.
It also introduces an
AtomicBooleaninNsdManagerto prevent multiple resume calls in the service resolution coroutine, improving its robustness. Additionally, theMeshActionHandleris refactored for better readability by extracting logic into separate private functions.