Refactor: Improve analytics plugin application and task configuration#4120
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4120 +/- ##
=====================================
Coverage 0.00% 0.00%
=====================================
Files 2 2
Lines 19 19
Branches 7 7
=====================================
Misses 19 19 ☔ View full report in Codecov by Sentry. |
Streamlined the `AnalyticsConventionPlugin` to enhance build performance and clarity. - Conditionally apply analytics plugins (Google Services, Firebase Crashlytics, Datadog) only for the "google" product flavor. - Improved task disabling logic for the "fdroid" flavor by using `plugins.withId` to configure tasks only when their respective plugins are present. This is more efficient than iterating over all tasks. - Replaced `extensions.configure<DdExtension>` with the safer `extensions.findByType<DdExtension>()?.apply` to avoid build errors if the plugin isn't applied.
eb4a746 to
8d0d8b4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Streamlined the
AnalyticsConventionPluginto enhance build performance and clarity.plugins.withIdto configure tasks only when their respective plugins are present. This is more efficient than iterating over all tasks.extensions.configure<DdExtension>with the saferextensions.findByType<DdExtension>()?.applyto avoid build errors if the plugin isn't applied.