Skip to content

Implements#4054 - Add channel name to channel message notification#4069

Merged
jamesarich merged 2 commits into
meshtastic:mainfrom
RaspberryProgramming:add-channel-to-notification
Dec 27, 2025
Merged

Implements#4054 - Add channel name to channel message notification#4069
jamesarich merged 2 commits into
meshtastic:mainfrom
RaspberryProgramming:add-channel-to-notification

Conversation

@RaspberryProgramming

@RaspberryProgramming RaspberryProgramming commented Dec 26, 2025

Copy link
Copy Markdown
Contributor

Closes #4054

Feature

I am looking to add the channel name to message notifications. It can be confusing whether a message is coming from a DM or from a channel on android. You can see from the screenshots below, the current design always shows the sender of the notification where the redesign would show the channel it is under if it's a channel message.

Current Notification Design
Image

Updated Channel Notification Design
Image

Testing

I tested the change on android 16. I also ran detekt and spotless.

Please see #4054

@codecov

codecov Bot commented Dec 27, 2025

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 11 lines in your changes missing coverage. Please review.
✅ Project coverage is 0.59%. Comparing base (5feee83) to head (4a12cad).
⚠️ Report is 15 commits behind head on main.

Files with missing lines Patch % Lines
...ville/mesh/service/MeshServiceNotificationsImpl.kt 0.00% 7 Missing ⚠️
...in/java/com/geeksville/mesh/service/MeshService.kt 0.00% 4 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##            main   #4069      +/-   ##
========================================
- Coverage   0.60%   0.59%   -0.01%     
========================================
  Files        406     407       +1     
  Lines      24457   24777     +320     
  Branches    3153    3186      +33     
========================================
  Hits         148     148              
- Misses     24286   24606     +320     
  Partials      23      23              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@DaneEvans DaneEvans added the enhancement New feature or request label Dec 27, 2025

@DaneEvans DaneEvans left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me, I like the idea

@jamesarich jamesarich added this pull request to the merge queue Dec 27, 2025
Merged via the queue into meshtastic:main with commit 250caa7 Dec 27, 2025
8 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature Request]: Add channel name to channel text notifications

3 participants