Skip to content

fix: fixes to improve chat view reliability, eliminates stutter#4053

Merged
jamesarich merged 4 commits into
meshtastic:mainfrom
mdecourcy:fix/chat-view-stutter
Dec 24, 2025
Merged

fix: fixes to improve chat view reliability, eliminates stutter#4053
jamesarich merged 4 commits into
meshtastic:mainfrom
mdecourcy:fix/chat-view-stutter

Conversation

@mdecourcy

Copy link
Copy Markdown
Contributor

No description provided.

Fixes edge case where new messages arriving in chat threads caused
visible stuttering/janking due to multiple concurrent scroll operations.

Changes:
- Consolidated multiple LaunchedEffect blocks into single scroll logic
  to prevent race conditions between refresh and itemCount triggers
- Added conditional item animations that disable during active scrolling
  to prevent competing animations with auto-scroll
- Optimized remote message count calculation using itemSnapshotList
  instead of index iteration to avoid triggering paging load states

The issue occurred when new messages arrived while the list was updating,
causing up to 3 simultaneous scroll operations. Now there's only one
unified scroll path.
@github-actions github-actions Bot added the bugfix PR tag label Dec 22, 2025
@codecov

codecov Bot commented Dec 22, 2025

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 14 lines in your changes missing coverage. Please review.
✅ Project coverage is 0.60%. Comparing base (79fe641) to head (ce7bcc7).
⚠️ Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
...g/meshtastic/feature/messaging/MessageListPaged.kt 0.00% 14 Missing ⚠️
Additional details and impacted files
@@          Coverage Diff          @@
##            main   #4053   +/-   ##
=====================================
  Coverage   0.60%   0.60%           
=====================================
  Files        406     406           
  Lines      24457   24447   -10     
  Branches    3153    3148    -5     
=====================================
  Hits         148     148           
+ Misses     24286   24276   -10     
  Partials      23      23           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jamesarich jamesarich added this pull request to the merge queue Dec 24, 2025
Merged via the queue into meshtastic:main with commit a1139b6 Dec 24, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bugfix PR tag

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants