refactor(build): Migrate core/common to KMP and cleanup build logic#4026
Merged
Conversation
This commit migrates the `core/common` module to a Kotlin Multiplatform (KMP) library. Key changes include: - Updating `core/common/build.gradle.kts` to use `meshtastic.kmp.library` and the `kotlin` block for configuration. - Reorganizing `core/common` source files into `androidMain` and `commonMain` source sets. - Removing the now-redundant `org.jetbrains.kotlin.plugin.compose` from the `KmpLibraryConventionPlugin` as it will be applied by modules that need it. - Explicitly adding the `compose.compiler` plugin to the `core/strings` module. Signed-off-by: James Rich <2199651+jamesarich@users.noreply.github.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4026 +/- ##
========================================
- Coverage 0.56% 0.56% -0.01%
========================================
Files 405 405
Lines 24136 24141 +5
Branches 3098 3099 +1
========================================
Hits 136 136
- Misses 23979 23984 +5
Partials 21 21 ☔ View full report in Codecov by Sentry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit migrates the
core/commonmodule to a Kotlin Multiplatform (KMP) library.Key changes include:
core/common/build.gradle.ktsto usemeshtastic.kmp.libraryand thekotlinblock for configuration.core/commonsource files intoandroidMainandcommonMainsource sets.org.jetbrains.kotlin.plugin.composefrom theKmpLibraryConventionPluginas it will be applied by modules that need it.compose.compilerplugin to thecore/stringsmodule.