refactor(analytics): Only plant DebugTree in debug builds#4025
Merged
Conversation
The `DebugTree` for Timber logging will now only be planted when the application is built in `DEBUG` mode. This is achieved by conditionally adding it to the list of trees to be planted based on the `BuildConfig.DEBUG` flag. Signed-off-by: James Rich <2199651+jamesarich@users.noreply.github.com>
40a66e2 to
f6e1aca
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4025 +/- ##
========================================
- Coverage 0.56% 0.56% -0.01%
========================================
Files 405 405
Lines 24136 24141 +5
Branches 3098 3099 +1
========================================
Hits 136 136
- Misses 23979 23984 +5
Partials 21 21 ☔ View full report in Codecov by Sentry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
DebugTreefor Timber logging will now only be planted when the application is built inDEBUGmode. This is achieved by conditionally adding it to the list of trees to be planted based on theBuildConfig.DEBUGflag.