Restructure node filters#4020
Merged
Merged
Conversation
jamesarich
approved these changes
Dec 16, 2025
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4020 +/- ##
========================================
- Coverage 0.56% 0.56% -0.01%
========================================
Files 404 404
Lines 24116 24135 +19
Branches 3098 3098
========================================
Hits 136 136
- Misses 23959 23978 +19
Partials 21 21 ☔ View full report in Codecov by Sentry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In addition to not being type safe, the current implementation is causing inference issues with Kotlin 2.3.0. This PR breaks up the Flow collection a bit to keep things working, but it has its limits (combines are limited to 5 Flows). This screen would be well-suited for Molecule.