fix(build): disable more analytics tasks for F-Droid builds#4000
Merged
Conversation
Expanded the list of keywords used to identify and disable analytics-related tasks for the `fdroid` build flavor. The keyword "buildId" has been added, and the matching logic is now case-insensitive to ensure tasks like `uploadCrashlyticsBuildIdFdroidRelease` are correctly disabled. Signed-off-by: James Rich <2199651+jamesarich@users.noreply.github.com>
6 tasks
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4000 +/- ##
=====================================
Coverage 0.57% 0.57%
=====================================
Files 401 401
Lines 23852 23852
Branches 3060 3060
=====================================
Hits 136 136
Misses 23695 23695
Partials 21 21 ☔ View full report in Codecov by Sentry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Expanded the list of keywords used to identify and disable analytics-related tasks for the
fdroidbuild flavor.The keyword "buildId" has been added, and the matching logic is now case-insensitive.
AnalyticsConventionPlugin: Disabling task processFdroidDebugGoogleServices
AnalyticsConventionPlugin: Disabling task injectCrashlyticsVersionControlInfoFdroidDebug
AnalyticsConventionPlugin: Disabling task injectCrashlyticsMappingFileIdFdroidDebug
AnalyticsConventionPlugin: Disabling task processFdroidReleaseGoogleServices
AnalyticsConventionPlugin: Disabling task injectCrashlyticsVersionControlInfoFdroidRelease
AnalyticsConventionPlugin: Disabling task injectCrashlyticsMappingFileIdFdroidRelease
AnalyticsConventionPlugin: Disabling task uploadCrashlyticsMappingFileFdroidRelease
AnalyticsConventionPlugin: Disabling task generateBuildIdFdroidRelease
Hopefully resolves #3231 (maybe this time?)