fix: nodes seen before full user exchange not being updated in phone NodeDB#3996
Merged
jamesarich merged 3 commits intoDec 17, 2025
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3996 +/- ##
========================================
- Coverage 0.56% 0.56% -0.01%
========================================
Files 405 405
Lines 24141 24150 +9
Branches 3099 3099
========================================
Hits 136 136
- Misses 23984 23993 +9
Partials 21 21 ☔ View full report in Codecov by Sentry. |
jamesarich
requested changes
Dec 13, 2025
jamesarich
left a comment
Collaborator
There was a problem hiding this comment.
@mdecourcy no proto pls 🙏
8 tasks
The proto submodule was accidentally updated. Reverting it back to the commit used in main (4095e598).
jamesarich
approved these changes
Dec 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When shouldPreserveExistingUser() returns true in installNodeInfo() and handleReceivedUser(), the code correctly preserves the existing user protobuf but fails to update the denormalized longName and shortName columns from the preserved data.
Result: Node has valid data in user.longName but NULL in the longName/shortName columns used for filtering
Should close #3992