Skip to content

feat: Optimize message list node lookup#3981

Merged
jamesarich merged 2 commits into
meshtastic:mainfrom
jamesarich:refactor/optimize-node-lookup
Dec 12, 2025
Merged

feat: Optimize message list node lookup#3981
jamesarich merged 2 commits into
meshtastic:mainfrom
jamesarich:refactor/optimize-node-lookup

Conversation

@jamesarich

Copy link
Copy Markdown
Collaborator

Pre-calculate a map of nodes for O(1) lookup within the message list items. This avoids an O(N) linear search for each item during scrolling, improving performance.

Pre-calculate a map of nodes for O(1) lookup within the message list items. This avoids an O(N) linear search for each item during scrolling, improving performance.
@github-actions github-actions Bot added the refactor no functional changes label Dec 12, 2025
Signed-off-by: James Rich <2199651+jamesarich@users.noreply.github.com>
@jamesarich jamesarich enabled auto-merge December 12, 2025 20:07
@codecov

codecov Bot commented Dec 12, 2025

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 0.57%. Comparing base (f322660) to head (1402dbb).
⚠️ Report is 7 commits behind head on main.

Files with missing lines Patch % Lines
...g/meshtastic/feature/messaging/MessageListPaged.kt 0.00% 6 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##            main   #3981      +/-   ##
========================================
+ Coverage   0.52%   0.57%   +0.04%     
========================================
  Files        395     401       +6     
  Lines      23172   23692     +520     
  Branches    2944    3042      +98     
========================================
+ Hits         122     136      +14     
- Misses     23029   23535     +506     
  Partials      21      21              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jamesarich jamesarich added this pull request to the merge queue Dec 12, 2025
Merged via the queue into meshtastic:main with commit 5759fb3 Dec 12, 2025
6 checks passed
@jamesarich jamesarich deleted the refactor/optimize-node-lookup branch December 12, 2025 20:39
@jamesarich jamesarich added this to the 2.7.10 milestone Dec 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

refactor no functional changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant