refactor: Move byte utilities to core:common module#3977
Merged
Conversation
This commit moves the `byteArrayOfInts` and `xorHash` utility functions from `core:model` to a new, more appropriate `core:common` module. This refactoring improves modularity by placing common byte manipulation utilities in a shared location, making them reusable across different parts of the application. The `core:model` module now depends on `core:common` to access these functions. Signed-off-by: James Rich <2199651+jamesarich@users.noreply.github.com>
Replaced the magic number `0xff` with a named constant `BYTE_MASK` to improve code readability and maintainability within the `xorHash` function. Signed-off-by: James Rich <2199651+jamesarich@users.noreply.github.com>
9ad4283 to
7f8c6ed
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3977 +/- ##
=====================================
Coverage 0.52% 0.52%
=====================================
Files 394 395 +1
Lines 23172 23172
Branches 2944 2944
=====================================
Hits 122 122
Misses 23029 23029
Partials 21 21 ☔ View full report in Codecov by Sentry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit moves the
byteArrayOfIntsandxorHashutility functions fromcore:modelto a new, more appropriatecore:commonmodule.This refactoring improves modularity by placing common byte manipulation utilities in a shared location, making them reusable across different parts of the application. The
core:modelmodule now depends oncore:commonto access these functions.