fix(nodes): Correctly filter ignored nodes#3966
Merged
Merged
Conversation
The filter for showing or hiding ignored nodes was not working as intended. This commit corrects the logic to properly filter the node list based on the `showIgnored` flag. Previously, the filter was `filter.showIgnored || !it.isIgnored`, which would always show non-ignored nodes, regardless of the filter setting. The new logic, `node.isIgnored == filter.showIgnored`, correctly displays only ignored nodes when `showIgnored` is true, and only non-ignored nodes when it is false. Signed-off-by: James Rich <2199651+jamesarich@users.noreply.github.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3966 +/- ##
=====================================
Coverage 0.52% 0.52%
=====================================
Files 394 394
Lines 23170 23170
Branches 2943 2943
=====================================
Hits 122 122
Misses 23027 23027
Partials 21 21 ☔ View full report in Codecov by Sentry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The filter for showing or hiding ignored nodes was not working as intended. This commit corrects the logic to properly filter the node list based on the
showIgnoredflag.Previously, the filter was
filter.showIgnored || !it.isIgnored, which would always show non-ignored nodes, regardless of the filter setting.The new logic,
node.isIgnored == filter.showIgnored, correctly displays only ignored nodes whenshowIgnoredis true, and only non-ignored nodes when it is false.resolves #3881