chore(build-logic): Apply Spotless and Detekt to build-logic module#3962
Merged
Conversation
This commit refactors the build logic to improve dependency and plugin management for code formatting.
- The `ktlint` version is now defined in the `libs.versions.toml` version catalog, centralizing version control.
- The `Spotless.kt` convention plugin now retrieves the `ktlint` version from the version catalog (`libs.findVersion("ktlint")`).
- The Spotless plugin is now applied to the `build-logic/convention` module itself, ensuring its own source code adheres to the project's formatting standards.
Signed-off-by: James Rich <2199651+jamesarich@users.noreply.github.com>
This commit integrates Detekt into the `build-logic` module to perform static code analysis on the build scripts themselves. - Added the Detekt plugin and formatting dependency to `build-logic/convention/build.gradle.kts`. - Configured the Detekt task, pointing to the root `detekt.yml` configuration file. - Introduced a baseline file (`detekt-baseline.xml`) to ignore existing code style issues within the build logic. Signed-off-by: James Rich <2199651+jamesarich@users.noreply.github.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3962 +/- ##
=====================================
Coverage 0.52% 0.52%
=====================================
Files 394 394
Lines 23170 23170
Branches 2943 2943
=====================================
Hits 122 122
Misses 23027 23027
Partials 21 21 ☔ View full report in Codecov by Sentry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ensures
:build-logicmodule adheres to code style (from now on)