Skip to content

fix: back button respects navigation history in detail screens#3956

Merged
jamesarich merged 1 commit into
meshtastic:mainfrom
mdecourcy:fix/navigator
Dec 10, 2025
Merged

fix: back button respects navigation history in detail screens#3956
jamesarich merged 1 commit into
meshtastic:mainfrom
mdecourcy:fix/navigator

Conversation

@mdecourcy

Copy link
Copy Markdown
Contributor

Fixes back navigation when entering node/contact details from other screens.

Previously, pressing back from node details after navigating from Messages would close the detail pane but remain in the Nodes section. Now properly returns to the originating screen (Messages, Map, etc.) by checking the NavController's back stack before closing the detail pane.

Extends fix from #3870 to handle cross-graph navigation.

@github-actions github-actions Bot added the bugfix PR tag label Dec 10, 2025
@codecov

codecov Bot commented Dec 10, 2025

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 10 lines in your changes missing coverage. Please review.
✅ Project coverage is 0.52%. Comparing base (6be1d16) to head (e2db8ae).
⚠️ Report is 11 commits behind head on main.

Files with missing lines Patch % Lines
...eksville/mesh/ui/contact/AdaptiveContactsScreen.kt 0.00% 5 Missing ⚠️
.../geeksville/mesh/ui/node/AdaptiveNodeListScreen.kt 0.00% 5 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##            main   #3956      +/-   ##
========================================
- Coverage   0.52%   0.52%   -0.01%     
========================================
  Files        394     394              
  Lines      23145   23170      +25     
  Branches    2933    2943      +10     
========================================
  Hits         122     122              
- Misses     23002   23027      +25     
  Partials      21      21              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jamesarich jamesarich left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@jamesarich jamesarich added this pull request to the merge queue Dec 10, 2025
Merged via the queue into meshtastic:main with commit 6e28041 Dec 10, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bugfix PR tag

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants