chore: Use repeatOnLifecycle for lifecycle-aware coroutine launch#3952
Merged
Conversation
This commit updates the `NodeRepository` to use `repeatOnLifecycle` instead of the deprecated `launchWhenCreated`. This ensures that the coroutine for backfilling denormalized node names is launched when the lifecycle is at least `CREATED` and is automatically cancelled when the lifecycle is `DESTROYED`, preventing potential resource leaks. Signed-off-by: James Rich <2199651+jamesarich@users.noreply.github.com>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3952 +/- ##
========================================
- Coverage 0.52% 0.52% -0.01%
========================================
Files 394 394
Lines 23161 23162 +1
Branches 2939 2939
========================================
Hits 122 122
- Misses 23018 23019 +1
Partials 21 21 ☔ View full report in Codecov by Sentry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit updates the
NodeRepositoryto userepeatOnLifecycleinstead of the deprecatedlaunchWhenCreated. This ensures that the coroutine for backfilling denormalized node names is launched when the lifecycle is at leastCREATEDand is automatically cancelled when the lifecycle isDESTROYED, preventing potential resource leaks.