feat(navigation): Navigate back to list view on tab reselection#3948
Merged
Conversation
This commit enhances the user experience in list-detail views by allowing users to navigate back to the list pane when re-selecting the currently active tab. If the user is viewing a detail screen (e.g., a specific conversation or node details) and taps the corresponding tab in the bottom navigation bar again, the app will now navigate back to the list view for that section. This provides an intuitive way to return to the list without using the back button. - Implemented a `LaunchedEffect` in `AdaptiveContactsScreen` and `AdaptiveNodeListScreen` to listen for tab reselection events. - When a `ScrollToTopEvent` for the current tab is received while on a detail pane, it triggers a back navigation to the list pane. - Updated `UIStateViewModel` to use `MutableSharedFlow` instead of `Channel` for emitting scroll-to-top events, ensuring better event handling. Signed-off-by: James Rich <2199651+jamesarich@users.noreply.github.com>
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #3948 +/- ##
========================================
- Coverage 0.52% 0.52% -0.01%
========================================
Files 394 394
Lines 23145 23161 +16
Branches 2933 2939 +6
========================================
Hits 122 122
- Misses 23002 23018 +16
Partials 21 21 ☔ View full report in Codecov by Sentry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit enhances the user experience in list-detail views by allowing users to navigate back to the list pane when re-selecting the currently active tab.
If the user is viewing a detail screen (e.g., a specific conversation or node details) and taps the corresponding tab in the bottom navigation bar again, the app will now navigate back to the list view for that section. This provides an intuitive way to return to the list without using the back button.
LaunchedEffectinAdaptiveContactsScreenandAdaptiveNodeListScreento listen for tab reselection events.ScrollToTopEventfor the current tab is received while on a detail pane, it triggers a back navigation to the list pane.UIStateViewModelto useMutableSharedFlowinstead ofChannelfor emitting scroll-to-top events, ensuring better event handling.resolves #3926