refactor(settings): Use string resources for update intervals#3937
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3937 +/- ##
========================================
- Coverage 0.52% 0.52% -0.01%
========================================
Files 394 394
Lines 23140 23145 +5
Branches 2933 2933
========================================
Hits 122 122
- Misses 22997 23002 +5
Partials 21 21 ☔ View full report in Codecov by Sentry. |
This commit refactors the `FixedUpdateIntervals` enum to use string and plural string resources for localization, replacing the previous method of generating display names from the enum constant names. - Updated `FixedUpdateIntervals` enum to include `textRes`, `pluralRes`, and `quantity` parameters for mapping each interval to its corresponding string resource. - Created a new `toDisplayString` extension function that uses `pluralStringResource` and `stringResource` to provide localized interval names. - Added new string and plural resources for seconds, minutes, hours, "Unset", and "Always On" to `strings.xml`. Signed-off-by: James Rich <2199651+jamesarich@users.noreply.github.com>
7758c8a to
0356818
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactors the
FixedUpdateIntervalsenum to use string and plural string resources for localization, replacing the previous method of generating display names from the enum constant names.FixedUpdateIntervalsenum to includetextRes,pluralRes, andquantityparameters for mapping each interval to its corresponding string resource.toDisplayStringextension function that usespluralStringResourceandstringResourceto provide localized interval names.strings.xml.resolves #3841