fix(maps): Enable lite mode and fix recomposition for inline maps#3936
Merged
Conversation
This commit addresses issues with the inline map component on the node detail screen. - Enabled Google Maps lite mode to improve performance and reduce resource consumption for the simple, non-interactive map view. - Wrapped the `GoogleMap` composable and its state in a `key(node.num)` block. This ensures that the map correctly recomposes and updates its camera position when the user navigates between different nodes, preventing a stale map from being displayed. Signed-off-by: James Rich <2199651+jamesarich@users.noreply.github.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3936 +/- ##
=====================================
Coverage 0.52% 0.52%
=====================================
Files 394 394
Lines 23140 23140
Branches 2933 2933
=====================================
Hits 122 122
Misses 22997 22997
Partials 21 21 ☔ View full report in Codecov by Sentry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit addresses issues with the inline map component on the node detail screen.
GoogleMapcomposable and its state in akey(node.num)block. This ensures that the map correctly recomposes and updates its camera position when the user navigates between different nodes, preventing a stale map from being displayed.resolves #3916