Skip to content

fix #3838 : message deletion count on the contacts page.#3924

Merged
jamesarich merged 2 commits into
meshtastic:mainfrom
DaneEvans:fix/3838_string_fill
Dec 7, 2025
Merged

fix #3838 : message deletion count on the contacts page.#3924
jamesarich merged 2 commits into
meshtastic:mainfrom
DaneEvans:fix/3838_string_fill

Conversation

@DaneEvans

Copy link
Copy Markdown
Collaborator

closes #3838

@github-actions github-actions Bot added the bugfix PR tag label Dec 7, 2025
@codecov

codecov Bot commented Dec 7, 2025

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 7 lines in your changes missing coverage. Please review.
✅ Project coverage is 0.52%. Comparing base (a242d99) to head (7f63ac6).
⚠️ Report is 5 commits behind head on main.

Files with missing lines Patch % Lines
...in/java/com/geeksville/mesh/ui/contact/Contacts.kt 0.00% 4 Missing ⚠️
...om/geeksville/mesh/ui/contact/ContactsViewModel.kt 0.00% 3 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##            main   #3924      +/-   ##
========================================
- Coverage   0.52%   0.52%   -0.01%     
========================================
  Files        394     394              
  Lines      23131   23136       +5     
  Branches    2932    2933       +1     
========================================
  Hits         122     122              
- Misses     22988   22993       +5     
  Partials      21      21              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Comment thread app/src/main/java/com/geeksville/mesh/ui/contact/Contacts.kt Outdated

@jamesarich jamesarich left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small nit for logging otherwise 👍

@jamesarich jamesarich enabled auto-merge December 7, 2025 12:37
@jamesarich jamesarich added this pull request to the merge queue Dec 7, 2025
Merged via the queue into meshtastic:main with commit 73f1ff0 Dec 7, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bugfix PR tag

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Delete messages popup missing number

2 participants