Revert "block creation or sending of duplicate channels. "#3921
Merged
Conversation
This reverts commit 7db7f61.
Collaborator
Legitimate use case of bridging presets with the same AQ== key is blocked with this change. If the node already had said double up of keys, everything still worked. If you tried to add a redundant key, it would be blocked, thereby stopping full UDP usage. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3921 +/- ##
=====================================
Coverage 0.52% 0.52%
=====================================
Files 394 394
Lines 23175 23131 -44
Branches 2941 2932 -9
=====================================
Hits 122 122
+ Misses 23032 22988 -44
Partials 21 21 ☔ View full report in Codecov by Sentry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #3913
@DaneEvans - this didn't work out with the UDP dependency that @b8b8 mentioned 😞 - he can fill in the details.