Skip to content

Fix/3894 talkback confusion#3914

Merged
jamesarich merged 4 commits into
meshtastic:mainfrom
DaneEvans:fix/3894_talkback_confusion
Dec 6, 2025
Merged

Fix/3894 talkback confusion#3914
jamesarich merged 4 commits into
meshtastic:mainfrom
DaneEvans:fix/3894_talkback_confusion

Conversation

@DaneEvans

@DaneEvans DaneEvans commented Dec 6, 2025

Copy link
Copy Markdown
Collaborator

closes #3894
and part of #2259
Drop the app icon from talkback

  • fix one of the QR Fabs
  • get the nav bar onto talkback

@github-actions github-actions Bot added the bugfix PR tag label Dec 6, 2025
@codecov

codecov Bot commented Dec 6, 2025

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 14 lines in your changes missing coverage. Please review.
✅ Project coverage is 0.53%. Comparing base (dbc5fd7) to head (4645761).
⚠️ Report is 18 commits behind head on main.

Files with missing lines Patch % Lines
app/src/main/java/com/geeksville/mesh/ui/Main.kt 0.00% 6 Missing ⚠️
...sh/ui/connections/components/ConnectionsNavIcon.kt 0.00% 4 Missing ⚠️
...lin/org/meshtastic/core/ui/component/MainAppBar.kt 0.00% 3 Missing ⚠️
...in/java/com/geeksville/mesh/ui/contact/Contacts.kt 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##            main   #3914      +/-   ##
========================================
- Coverage   0.53%   0.53%   -0.01%     
========================================
  Files        392     392              
  Lines      22940   22945       +5     
  Branches    2894    2894              
========================================
  Hits         122     122              
- Misses     22797   22802       +5     
  Partials      21      21              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@DaneEvans DaneEvans added this pull request to the merge queue Dec 6, 2025
@DaneEvans DaneEvans removed this pull request from the merge queue due to a manual request Dec 6, 2025
@jamesarich jamesarich added this pull request to the merge queue Dec 6, 2025
Merged via the queue into meshtastic:main with commit f322eb3 Dec 6, 2025
8 checks passed
@DaneEvans DaneEvans deleted the fix/3894_talkback_confusion branch December 7, 2025 00:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bugfix PR tag

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Application symbol button is disabled when using the talkback screen reader

2 participants