Persist downloaded nodes when installing node info#3899
Closed
Jord-JD wants to merge 2 commits into
Closed
Conversation
Collaborator
|
closing in favor of #3932 - thank you! |
Contributor
Author
|
Fair enough. Thanks for taking a look. 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a possible fix for #3898 which I just reported.
I've built an APK (Google Debug) with this change, and tested it locally myself and it appears to fix the issue.
However, I'm new to this code base, and generally have not done much native Android app development, so it is very possible I have misunderstood something and/or this is not the best approach.
The general idea here is:
My understanding is that the downloaded node DB wasn’t persisted during installNodeInfo because updateNodeInfo only upserted when haveNodeDB was true. As a result, nodes that existed only in the initial download never reached the database and didn’t show up in the node list until they later transmitted.
I do not fully understand why this bug is only coming up for some people, but I think it only surfaces when the nodes in the downloaded DB stay quiet after the initial sync; if the mesh is chatty, those nodes later transmit and get persisted, masking the issue.