feat(model): Make NetworkDeviceHardware robust to unknown JSON keys#3880
Merged
Conversation
This commit enhances the `NetworkDeviceHardware` data class by adding the `@JsonIgnoreUnknownKeys` annotation. This makes JSON deserialization more resilient by preventing crashes if the `devices.json` file contains new, unknown properties. Additionally, two new nullable fields, `key` and `variant`, have been added to the model to support future device definitions. The `kotlinx-serialization-json` dependency has been included in the `core/model` module to support these changes. Signed-off-by: James Rich <2199651+jamesarich@users.noreply.github.com>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3880 +/- ##
========================================
- Coverage 0.53% 0.53% -0.01%
========================================
Files 392 392
Lines 22938 22940 +2
Branches 2894 2894
========================================
Hits 122 122
- Misses 22795 22797 +2
Partials 21 21 ☔ View full report in Codecov by Sentry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit enhances the
NetworkDeviceHardwaredata class by adding the@JsonIgnoreUnknownKeysannotation. This makes JSON deserialization more resilient by preventing crashes if thedevices.jsonfile contains new, unknown properties.Additionally, two new nullable fields,
keyandvariant, have been added to the model to support future device definitions. Thekotlinx-serialization-jsondependency has been included in thecore/modelmodule to support these changes.