Skip to content

feat(navigation): Implement adaptive list-detail for contacts and nodes#3850

Merged
jamesarich merged 1 commit into
mainfrom
feat/adaptive-list-detail
Nov 29, 2025
Merged

feat(navigation): Implement adaptive list-detail for contacts and nodes#3850
jamesarich merged 1 commit into
mainfrom
feat/adaptive-list-detail

Conversation

@jamesarich

@jamesarich jamesarich commented Nov 29, 2025

Copy link
Copy Markdown
Collaborator

Introduces ListDetailPaneScaffold from Material 3 Adaptive to create adaptive layouts for the Contacts and Nodes screens, providing a two-pane view on larger screens.

  • Added AdaptiveContactsScreen to display a contact list and message view side-by-side.
  • Added AdaptiveNodeListScreen to show a node list and node details concurrently.
  • Updated ContactsNavigation and NodesNavigation to use these new adaptive screens.
  • Refactored MetricsViewModel to dynamically update its nodeId and re-initialize data flows when the selected node changes in the UI.
  • Passed destNum to NodeDetailRoutes to ensure metrics screens display data for the correct node.
  • Added a visual indicator for the currently active item in both the contact and node lists.
  • Included necessary Material 3 Adaptive dependencies (adaptive-layout, adaptive-navigation).
image image

… and nodes

This commit introduces `ListDetailPaneScaffold` from Material 3 Adaptive to create adaptive layouts for the Contacts and Nodes screens, providing a two-pane view on larger screens.

- Added `AdaptiveContactsScreen` to display a contact list and message view side-by-side.
- Added `AdaptiveNodeListScreen` to show a node list and node details concurrently.
- Updated `ContactsNavigation` and `NodesNavigation` to use these new adaptive screens.
- Refactored `MetricsViewModel` to dynamically update its `nodeId` and re-initialize data flows when the selected node changes in the UI.
- Passed `destNum` to `NodeDetailRoutes` to ensure metrics screens display data for the correct node.
- Added a visual indicator for the currently active item in both the contact and node lists.
- Included necessary Material 3 Adaptive dependencies (`adaptive-layout`, `adaptive-navigation`).

Signed-off-by: James Rich <2199651+jamesarich@users.noreply.github.com>
@github-actions github-actions Bot added the enhancement New feature or request label Nov 29, 2025
@jamesarich jamesarich added this pull request to the merge queue Nov 29, 2025
Merged via the queue into main with commit 78274c7 Nov 29, 2025
7 checks passed
@jamesarich jamesarich deleted the feat/adaptive-list-detail branch November 29, 2025 02:38
@codecov

codecov Bot commented Nov 29, 2025

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 306 lines in your changes missing coverage. Please review.
✅ Project coverage is 0.53%. Comparing base (5a413d0) to head (78e13fd).
⚠️ Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
...eshtastic/feature/node/metrics/MetricsViewModel.kt 0.00% 96 Missing ⚠️
...eksville/mesh/ui/contact/AdaptiveContactsScreen.kt 0.00% 55 Missing ⚠️
.../geeksville/mesh/ui/node/AdaptiveNodeListScreen.kt 0.00% 54 Missing ⚠️
.../com/geeksville/mesh/navigation/NodesNavigation.kt 0.00% 26 Missing ⚠️
...java/com/geeksville/mesh/ui/contact/ContactItem.kt 0.00% 15 Missing ⚠️
...tlin/org/meshtastic/feature/node/model/LogsType.kt 0.00% 10 Missing ⚠️
...in/java/com/geeksville/mesh/ui/contact/Contacts.kt 0.00% 9 Missing ⚠️
...in/kotlin/org/meshtastic/core/navigation/Routes.kt 0.00% 9 Missing ⚠️
...g/meshtastic/feature/messaging/MessageViewModel.kt 0.00% 7 Missing ⚠️
...m/geeksville/mesh/navigation/ContactsNavigation.kt 0.00% 6 Missing ⚠️
... and 7 more
Additional details and impacted files
@@           Coverage Diff            @@
##            main   #3850      +/-   ##
========================================
- Coverage   0.53%   0.53%   -0.01%     
========================================
  Files        386     388       +2     
  Lines      22618   22757     +139     
  Branches    2841    2875      +34     
========================================
  Hits         122     122              
- Misses     22475   22614     +139     
  Partials      21      21              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants