Skip to content

feat: prevent QR imports from overriding local TX power#3845

Merged
jamesarich merged 1 commit into
meshtastic:mainfrom
mdecourcy:feat/safe-qr-channel-config
Nov 28, 2025
Merged

feat: prevent QR imports from overriding local TX power#3845
jamesarich merged 1 commit into
meshtastic:mainfrom
mdecourcy:feat/safe-qr-channel-config

Conversation

@mdecourcy

Copy link
Copy Markdown
Contributor

No description provided.

@github-actions github-actions Bot added the enhancement New feature or request label Nov 28, 2025

@jamesarich jamesarich left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel like we could use a more thorough audit/alignment cross platform on what should/shouldn't be included in the QR code/uri encoding - but this is a safe start.

@mdecourcy

Copy link
Copy Markdown
Contributor Author

I feel like we could use a more thorough audit/alignment cross platform on what should/shouldn't be included in the QR code/uri encoding - but this is a safe start.

Agreed

@jamesarich jamesarich added this pull request to the merge queue Nov 28, 2025
Merged via the queue into meshtastic:main with commit d1e7bd1 Nov 28, 2025
5 checks passed
@codecov

codecov Bot commented Nov 28, 2025

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 0.54%. Comparing base (1c0dc48) to head (3df1418).
⚠️ Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
...n/org/meshtastic/core/ui/qr/ScannedQrCodeDialog.kt 0.00% 5 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##            main   #3845      +/-   ##
========================================
- Coverage   0.54%   0.54%   -0.01%     
========================================
  Files        386     386              
  Lines      22563   22589      +26     
  Branches    2838    2837       -1     
========================================
  Hits         122     122              
- Misses     22420   22446      +26     
  Partials      21      21              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants