Skip to content

fix: duplicate LazyColumn keys for broadcast contacts#3840

Merged
jamesarich merged 4 commits into
meshtastic:mainfrom
mdecourcy:fix/duplicate-column-keys
Nov 28, 2025
Merged

fix: duplicate LazyColumn keys for broadcast contacts#3840
jamesarich merged 4 commits into
meshtastic:mainfrom
mdecourcy:fix/duplicate-column-keys

Conversation

@mdecourcy

Copy link
Copy Markdown
Contributor

Ensure all contact and share lists use unique, stable keys in LazyColumn/paging by combining contactKey with the item index, preventing IllegalArgumentException: Key "0^all" was already used crashes while preserving existing selection and navigation behavior.

@github-actions github-actions Bot added the bugfix PR tag label Nov 27, 2025
The refactoring in the previous commit broke the build because LazyListScope
wasn't imported. Extension functions need this import to resolve properly.
@jamesarich jamesarich added this pull request to the merge queue Nov 28, 2025
Merged via the queue into meshtastic:main with commit af9a837 Nov 28, 2025
5 checks passed
@codecov

codecov Bot commented Nov 28, 2025

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 68 lines in your changes missing coverage. Please review.
✅ Project coverage is 0.54%. Comparing base (1c37842) to head (63cde8e).
⚠️ Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
...in/java/com/geeksville/mesh/ui/contact/Contacts.kt 0.00% 67 Missing ⚠️
.../main/java/com/geeksville/mesh/ui/sharing/Share.kt 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##            main   #3840      +/-   ##
========================================
- Coverage   0.54%   0.54%   -0.01%     
========================================
  Files        386     386              
  Lines      22559   22583      +24     
  Branches    2838    2838              
========================================
  Hits         122     122              
- Misses     22416   22440      +24     
  Partials      21      21              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bugfix PR tag

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants