fix: node search by keeping denormalized name columns up to date and backfilling existing nodes#3839
Merged
jamesarich merged 1 commit intoNov 28, 2025
Conversation
…backfilling existing nodes
jamesarich
approved these changes
Nov 28, 2025
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3839 +/- ##
========================================
- Coverage 0.54% 0.54% -0.01%
========================================
Files 386 386
Lines 22559 22563 +4
Branches 2838 2838
========================================
Hits 122 122
- Misses 22416 22420 +4
Partials 21 21 ☔ View full report in Codecov by Sentry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this change does
NodeEntityvalidation inNodeInfoDaoso that on every upsert we:user.publicKeyintoNodeEntity.publicKey(for lazy migration and consistency).longNameandshortNamefrom theMeshProtos.Userpayload when the user is not a placeholder (hwModel != UNSET).backfillDenormalizedNames()DAO method (exposed viaNodeInfoWriteDataSourceandSwitchingNodeInfoWriteDataSource) that:longName/shortNamefrom the associateduserprotobuf.NodeRepositorynow kicks off the backfill inprocessLifecycle.coroutineScope.launchWhenCreatedon the IO dispatcher so existing databases get corrected without blocking the UI.NodeRepository.getNodes(...)exposes a flow backed by the Room query inNodeInfoDao.getNodes, which now searches against the denormalizedlong_name/short_namecolumns and node ID (both hex and decimal).NodeListViewModelcombines user preferences and filter state into a singleNodeFilterState, then callsnodeRepository.getNodeswithsort,filterText, and flags (includeUnknown,onlyOnline,onlyDirect, infrastructure/ignored filters).unfilteredNodeListflow is provided for call sites that need the raw list without UI filters.Why this fixes the bug