fix: skip default nodeinfo upsert in handleReceivedUser for live packets#3819
Merged
DaneEvans merged 2 commits intoNov 26, 2025
Merged
Conversation
DaneEvans
approved these changes
Nov 26, 2025
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3819 +/- ##
========================================
- Coverage 0.56% 0.54% -0.02%
========================================
Files 381 386 +5
Lines 21747 22493 +746
Branches 2687 2821 +134
========================================
Hits 122 122
- Misses 21605 22350 +745
- Partials 20 21 +1 ☔ View full report in Codecov by Sentry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extends the fix from commit 5520978 to also protect handleReceivedUser(), which processes live NODEINFO_APP packets from the mesh.
The original fix only protected installNodeInfo() (initial device sync), but live NodeInfo packets were still overwriting user data through handleReceivedUser() without any protection against default names.
Changes:
This ensures that when firmware's NodeDB evicts a node and later re-creates it with default info ("Meshtastic XXXX", hwModel=UNSET), the app detects this in both code paths and preserves existing user data instead of overwriting it.
Fixes issue where user names were still being reset to defaults despite the original fix