fix: message list paged lifecycle resulting in notifications being cleared#3815
Merged
jamesarich merged 4 commits intoNov 26, 2025
Merged
Conversation
jamesarich
approved these changes
Nov 26, 2025
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3815 +/- ##
========================================
- Coverage 0.54% 0.54% -0.01%
========================================
Files 386 386
Lines 22484 22494 +10
Branches 2820 2821 +1
========================================
Hits 122 122
- Misses 22341 22351 +10
Partials 21 21 ☔ View full report in Codecov by Sentry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes a bug where message notifications were being cleared after 3 seconds even when the app was backgrounded or the screen was locked. The unread debounce timer now only marks messages as read and clears notifications when the message thread is actually visible to the user. This was introduced during my pagination work.
Problem: When a user left a message thread open and locked their screen or backgrounded the app, incoming message notifications would automatically disappear after 3 seconds due to the unread debounce continuing to run in the background.
Solution: Added lifecycle awareness to the UpdateUnreadCountPaged composable. The debounce now: