Skip to content

feat: Keep screen on during firmware update#3806

Merged
jamesarich merged 1 commit into
mainfrom
feat/screen-on-update
Nov 25, 2025
Merged

feat: Keep screen on during firmware update#3806
jamesarich merged 1 commit into
mainfrom
feat/screen-on-update

Conversation

@jamesarich

Copy link
Copy Markdown
Collaborator

This commit prevents the device screen from turning off during the firmware update process to ensure the user can monitor its progress without interruption.

  • Added a KeepScreenOn composable that sets the keepScreenOn flag on the current View.
  • The screen is kept on during the Downloading, Processing, and Updating states of the firmware update flow.
  • The flag is cleared when the process is complete or the composable is disposed.

This commit prevents the device screen from turning off during the firmware update process to ensure the user can monitor its progress without interruption.

- Added a `KeepScreenOn` composable that sets the `keepScreenOn` flag on the current `View`.
- The screen is kept on during the `Downloading`, `Processing`, and `Updating` states of the firmware update flow.
- The flag is cleared when the process is complete or the composable is disposed.

Signed-off-by: James Rich <2199651+jamesarich@users.noreply.github.com>
@github-actions github-actions Bot added the enhancement New feature or request label Nov 25, 2025
@codecov

codecov Bot commented Nov 25, 2025

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 14 lines in your changes missing coverage. Please review.
✅ Project coverage is 0.54%. Comparing base (022652e) to head (921a905).
⚠️ Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
...eshtastic/feature/firmware/FirmwareUpdateScreen.kt 0.00% 14 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##            main   #3806      +/-   ##
========================================
- Coverage   0.54%   0.54%   -0.01%     
========================================
  Files        386     386              
  Lines      22470   22484      +14     
  Branches    2815    2820       +5     
========================================
  Hits         122     122              
- Misses     22327   22341      +14     
  Partials      21      21              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jamesarich jamesarich added this pull request to the merge queue Nov 25, 2025
Merged via the queue into main with commit a2345da Nov 25, 2025
6 checks passed
@jamesarich jamesarich deleted the feat/screen-on-update branch November 25, 2025 14:28
@jamesarich jamesarich added this to the 2.7.8 milestone Nov 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant