refactor(connections): Improve RSSI reading robustness#3804
Merged
Conversation
This commit enhances the reliability of the RSSI (Received Signal Strength Indicator) reading for connected BLE devices. - Introduces a 5-second timeout for the `readRssi` operation to prevent indefinite hangs. - Implements more specific exception handling for `PeripheralNotConnectedException`, `OperationFailedException`, and `SecurityException` to gracefully exit the reading loop and provide clearer error logging. - Removes the generic `Exception` catch block for more precise error management. - Extracts magic numbers for the RSSI reading delay and timeout into named constants (`RSSI_DELAY`, `RSSI_TIMEOUT`). Signed-off-by: James Rich <2199651+jamesarich@users.noreply.github.com>
Signed-off-by: James Rich <2199651+jamesarich@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes crash @mdecourcy was seeing on main, slight adjustment to connection timing